Emil_Shanaty/Faset_Engine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Compare source-open Unicode argv against canonical paths
Native and manual checks / native (ubuntu-24.04) (push) Failing after 30s
Details
Native and manual checks / manual (push) Successful in 28s
Details
Windows editor and software Vulkan / windows-graphics (push) Canceled after 0s
Details
Native and manual checks / native (windows-2025) (push) Canceled after 0s
Details

Browse Source
This commit is contained in:
Emil
2026-09-24 02:46:07 +03:00
parent a68fb8e7fd
commit 62059e154d
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/editor_session_tests.cpp
+11 -6
View File
@@ -177,12 +177,17 @@ int test_main(int argc, char** argv) {
"{file}:{line}:{column}", "{project}"})}}); "{file}:{line}:{column}", "{project}"})}});
for (int attempt = 0; attempt < 100 && !std::filesystem::exists(probe); ++attempt) for (int attempt = 0; attempt < 100 && !std::filesystem::exists(probe); ++attempt)
std::this_thread::sleep_for(std::chrono::milliseconds(10)); std::this_thread::sleep_for(std::chrono::milliseconds(10));
const auto canonical_root = std::filesystem::weakly_canonical(root);
const auto expected_source = project_path(root, "Scripts/Gameplay.cpp");
const auto expected_arguments =
Json::array({path_to_utf8(expected_source) + ":17:4", path_to_utf8(canonical_root)});
const auto actual_arguments =
std::filesystem::is_regular_file(probe) ? read_json(probe) : Json(nullptr);
require(opened.at("path") == "Scripts/Gameplay.cpp" && opened.at("line") == 17 && require(opened.at("path") == "Scripts/Gameplay.cpp" && opened.at("line") == 17 &&
std::filesystem::is_regular_file(probe) && actual_arguments == expected_arguments,
read_json(probe) == "test", "Source navigation passes a Unicode path and location as literal argv; "
Json::array({path_to_utf8(root / "Scripts/Gameplay.cpp") + ":17:4", "expected " + expected_arguments.dump() + ", got " +
path_to_utf8(root)}), actual_arguments.dump());
"test", "Source navigation passes a Unicode path and location as literal argv");
reject_command("faset_source_open", {{"path", "../outside.cpp"}}, "source.path"); reject_command("faset_source_open", {{"path", "../outside.cpp"}}, "source.path");
reject_command("faset_source_open", {{"path", "Scripts/missing.cpp"}}, "source.path"); reject_command("faset_source_open", {{"path", "Scripts/missing.cpp"}}, "source.path");
reject_command("faset_source_open", {{"path", "Scripts"}}, "source.path"); reject_command("faset_source_open", {{"path", "Scripts"}}, "source.path");
@@ -233,7 +238,7 @@ int test_main(int argc, char** argv) {
"configuration preservation and Lua editor commands passed\n"; "configuration preservation and Lua editor commands passed\n";
return 0; return 0;
} catch (const std::exception& error) { } catch (const std::exception& error) {
std::cerr << error.what() << "\nFixture retained at " << root << '\n'; std::cerr << error.what() << "\nFixture retained at " << path_to_utf8(root) << '\n';
return 1; return 1;
} }
} }