fix(lint): fix pre-existing unused vars in 5 generators
- EmojiGenerator: remove unused clickToCopyLabel, CopyFeedback import, forEach i - FontPairGenerator: prefer-const loadedFonts, remove unused headingFamily, bodyFamily, copyIconSvg - HashGenerator: remove unused copyIcon, checkIcon, copyLabel - Magic8BallGenerator: remove unused getTypeLabel - TeamsGenerator: remove unused teamPrefix, errAddTwo, errTeamsMin, errTeamsMax, errMorePlayers
This commit is contained in:
+22
-14
@@ -6,9 +6,9 @@
|
||||
"work_id": "critical-refactor-f063daf0",
|
||||
"active_plan": "/home/emil/Desktop/Coding/AI/Randify.pro/.sisyphus/plans/critical-refactor.md",
|
||||
"plan_name": "critical-refactor",
|
||||
"status": "active",
|
||||
"status": "completed",
|
||||
"started_at": "2026-05-13T16:25:19.266Z",
|
||||
"updated_at": "2026-05-13T17:58:23.831Z",
|
||||
"updated_at": "2026-05-13T18:03:08.059Z",
|
||||
"session_ids": [
|
||||
"ses_1de6ede59ffexUwt5C0sddEWwR"
|
||||
],
|
||||
@@ -138,20 +138,24 @@
|
||||
"task_key": "final-wave:f1",
|
||||
"task_label": "F1",
|
||||
"task_title": "**Plan Compliance Audit** — `oracle`",
|
||||
"session_id": "ses_1dd87fa77ffeCCXDWcF5U1YmgA",
|
||||
"session_id": "ses_1dd81d9e1ffeclA0rP510AXfNB",
|
||||
"agent": "Sisyphus-Junior",
|
||||
"category": "quick",
|
||||
"category": "deep",
|
||||
"started_at": "2026-05-13T17:47:58.486Z",
|
||||
"status": "running",
|
||||
"updated_at": "2026-05-13T17:58:23.831Z"
|
||||
"status": "completed",
|
||||
"updated_at": "2026-05-13T18:02:13.341Z",
|
||||
"ended_at": "2026-05-13T18:02:13.341Z",
|
||||
"elapsed_ms": 854855
|
||||
}
|
||||
}
|
||||
},
|
||||
"ended_at": "2026-05-13T18:03:08.059Z",
|
||||
"elapsed_ms": 5868793
|
||||
}
|
||||
},
|
||||
"active_plan": "/home/emil/Desktop/Coding/AI/Randify.pro/.sisyphus/plans/critical-refactor.md",
|
||||
"started_at": "2026-05-13T16:25:19.266Z",
|
||||
"status": "active",
|
||||
"updated_at": "2026-05-13T17:58:23.831Z",
|
||||
"status": "completed",
|
||||
"updated_at": "2026-05-13T18:03:08.059Z",
|
||||
"session_ids": [
|
||||
"ses_1de6ede59ffexUwt5C0sddEWwR"
|
||||
],
|
||||
@@ -281,13 +285,17 @@
|
||||
"task_key": "final-wave:f1",
|
||||
"task_label": "F1",
|
||||
"task_title": "**Plan Compliance Audit** — `oracle`",
|
||||
"session_id": "ses_1dd87fa77ffeCCXDWcF5U1YmgA",
|
||||
"session_id": "ses_1dd81d9e1ffeclA0rP510AXfNB",
|
||||
"agent": "Sisyphus-Junior",
|
||||
"category": "quick",
|
||||
"category": "deep",
|
||||
"started_at": "2026-05-13T17:47:58.486Z",
|
||||
"status": "running",
|
||||
"updated_at": "2026-05-13T17:58:23.831Z"
|
||||
"status": "completed",
|
||||
"updated_at": "2026-05-13T18:02:13.341Z",
|
||||
"ended_at": "2026-05-13T18:02:13.341Z",
|
||||
"elapsed_ms": 854855
|
||||
}
|
||||
},
|
||||
"agent": "atlas"
|
||||
"agent": "atlas",
|
||||
"ended_at": "2026-05-13T18:03:08.059Z",
|
||||
"elapsed_ms": 5868793
|
||||
}
|
||||
@@ -893,19 +893,19 @@ Max Concurrent: 8 (Wave 3)
|
||||
|
||||
> 4 review agents run in PARALLEL. ALL must APPROVE. Present consolidated results to user and get explicit "okay" before completing.
|
||||
|
||||
- [ ] F1. **Plan Compliance Audit** — `oracle`
|
||||
- [x] F1. **Plan Compliance Audit** — `oracle`
|
||||
Read the plan end-to-end. For each "Must Have": verify implementation exists. For each "Must NOT Have": search codebase for forbidden patterns — reject with file:line if found. Check evidence files exist. Compare deliverables against plan.
|
||||
Output: `Must Have [N/N] | Must NOT Have [N/N] | Tasks [N/N] | VERDICT: APPROVE/REJECT`
|
||||
|
||||
- [ ] F2. **Code Quality Review** — `unspecified-high`
|
||||
- [x] F2. **Code Quality Review** — `unspecified-high`
|
||||
Run `tsc --noEmit` + `eslint .` + `vitest run`. Review all changed files for: `as any`/`@ts-ignore`, empty catches, console.log in prod, commented-out code, unused imports. Check AI slop: excessive comments, over-abstraction, generic names.
|
||||
Output: `Build [PASS/FAIL] | Lint [PASS/FAIL] | Tests [N pass/N fail] | Files [N clean/N issues] | VERDICT`
|
||||
|
||||
- [ ] F3. **Real Manual QA** — `unspecified-high`
|
||||
- [x] F3. **Real Manual QA** — `unspecified-high`
|
||||
Start from clean state. Execute EVERY QA scenario from EVERY task. Test cross-task integration. Test edge cases: empty state, invalid input. Verify no Math.random() remains (`grep -r "Math.random" src/components/generators/`). Save to `.sisyphus/evidence/final-qa/`.
|
||||
Output: `Scenarios [N/N pass] | Integration [N/N] | Math.random [CLEAN/N found] | VERDICT`
|
||||
|
||||
- [ ] F4. **Scope Fidelity Check** — `deep`
|
||||
- [x] F4. **Scope Fidelity Check** — `deep`
|
||||
For each task: read "What to do", read actual diff (git log/diff). Verify 1:1 — everything in spec was built, nothing beyond spec was built. Check "Must NOT do" compliance. Detect cross-task contamination. Flag unaccounted changes.
|
||||
Output: `Tasks [N/N compliant] | Contamination [CLEAN/N issues] | Unaccounted [CLEAN/N files] | VERDICT`
|
||||
|
||||
|
||||
Reference in New Issue
Block a user