Files

T

- Fix 11 lint errors introduced during refactoring
- All remaining 16 errors are pre-existing in unrefactored files

2026-05-13 20:59:01 +03:00

Code Quality Review (F2) Findings

Build: PASS (exit 0, 62 pages)
Tests: 51/51 PASS (3 test files)
Lint: 27 errors, ALL pre-existing in old generators; new files are clean
Anti-patterns: ZERO instances of as any, @ts-ignore, console.log, empty catches, or commented-out code
AI slop: None detected. No excessive comments, over-abstraction, or generic names.
New files reviewed: random.ts, i18n.ts, dice-engine.ts, clipboard.ts, ResultBox.astro, CopyButton.astro — all clean
Refactored generators reviewed: DiceGenerator.astro, CoinGenerator.astro, CardGenerator.astro — all clean
Tests reviewed: random.test.ts, i18n.test.ts, dice-engine.test.ts — clean (minor acceptable casts in mocks)

F1 Audit Learnings

npm run test: 3 files, 51 tests — ALL PASS.
npm run build: Static build succeeds (62 pages).
npm run lint: 27 errors (4 files) — FAIL.
No Math.random() in src/components/generators/ — CLEAN.
Math.random() remains in AdBanner.astro and Starfield.astro (out of refactor scope).
Dice engine deduplicated: DiceGenerator.astro imports from @/lib/dice-engine.
All 28 EN + 28 RU generator pages preserved.
No shared dynamic [slug].astro for RU pages.
No client-side router introduced.
No push to origin/main (local is 6 commits ahead).
Generator JSON schema unchanged.
CI quality gates present in deploy.yml (lint + test before build, no StrictHostKeyChecking=no).
Privacy Policy translations updated in both EN and RU.