Efremenko Arhip
c8c6455caf
With a UI session, the dashboard and job pages are scoped to the caller: - Overview lists only the user's own jobs (admin/basic-auth operator: all) - JobDetail, artifact download, and preview 404 on another user's job - scoping keys off authctx: no requester (basic auth) still sees everything, so the fallback operator UI is unchanged ListJobs gains an owner filter (SQL WHERE) so paging stays correct per user. Tests cover Overview scoping and cross-user JobDetail rejection.
52 lines
1.6 KiB
Go
52 lines
1.6 KiB
Go
package usecase
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/google/uuid"
|
|
|
|
"github.com/emil28092005/SciMesh/coordinator/internal/authctx"
|
|
"github.com/emil28092005/SciMesh/coordinator/internal/domain"
|
|
)
|
|
|
|
// ownerFromContext returns the authenticated user id to stamp on a new job, or
|
|
// nil when the request was not authenticated as a user — worker or legacy
|
|
// traffic, or user-JWT auth disabled. A nil owner is stored as NULL.
|
|
func ownerFromContext(ctx context.Context) *uuid.UUID {
|
|
if r, ok := authctx.From(ctx); ok {
|
|
id := r.UserID
|
|
return &id
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// uiOwnerFilter returns the owner a UI listing must be restricted to: nil for an
|
|
// operator/admin or an unauthenticated (basic-auth) session, which see all jobs,
|
|
// or the caller's id for a plain user, who sees only their own.
|
|
func uiOwnerFilter(ctx context.Context) *uuid.UUID {
|
|
r, ok := authctx.From(ctx)
|
|
if !ok || r.IsAdmin() {
|
|
return nil
|
|
}
|
|
id := r.UserID
|
|
return &id
|
|
}
|
|
|
|
// authorizeJobAccess enforces that a non-admin user may only act on their own
|
|
// job. It returns ErrJobNotFound — not a 403 — on a mismatch, so the response
|
|
// never reveals that another user's job exists.
|
|
//
|
|
// Requests with no authenticated user (worker/legacy traffic, or JWT auth
|
|
// disabled) are not restricted here: the shared service token already gated
|
|
// them, and worker endpoints legitimately operate across all jobs.
|
|
func authorizeJobAccess(ctx context.Context, job *domain.Job) error {
|
|
r, ok := authctx.From(ctx)
|
|
if !ok || r.IsAdmin() {
|
|
return nil
|
|
}
|
|
if job.OwnerID == nil || *job.OwnerID != r.UserID {
|
|
return domain.ErrJobNotFound
|
|
}
|
|
return nil
|
|
}
|