fix: prevent null crashes in users and notes routers (#20279)

Add null checks for ui settings in update_user_settings_by_session_user() and for user in get_notes(). Prevents AttributeError when ui dict is None or when note's user has been deleted.
This commit is contained in:
Classic298
2025-12-31 02:30:14 -05:00
committed by GitHub
parent a2e9263af0
commit 2c0ebbcced
2 changed files with 17 additions and 14 deletions
+14 -13
View File
@@ -70,19 +70,20 @@ async def get_notes(
limit = 60
skip = (page - 1) * limit
notes = [
NoteUserResponse(
**{
**note.model_dump(),
"user": UserResponse(
**Users.get_user_by_id(note.user_id, db=db).model_dump()
),
}
)
for note in Notes.get_notes_by_user_id(
user.id, "read", skip=skip, limit=limit, db=db
)
]
notes = []
for note in Notes.get_notes_by_user_id(
user.id, "read", skip=skip, limit=limit, db=db
):
note_user = Users.get_user_by_id(note.user_id, db=db)
if note_user:
notes.append(
NoteUserResponse(
**{
**note.model_dump(),
"user": UserResponse(**note_user.model_dump()),
}
)
)
return notes