Emil_Shanaty/open-webui-ai4me
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf: use set for O(1) lookup in insert_chat_files dedupe (#23800)

Browse Source 
Convert chat_message_file_ids from list to set so the membership test
in the comprehension is O(1) instead of O(m), turning the dedupe from
O(n*m) into O(n+m). Also replace the redundant set([...]) with a set
comprehension.

https://claude.ai/code/session_01Le3NnqNhcgaJvFrDZGqmwe

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Classic298
2026-04-17 12:28:34 +09:00
committed by GitHub
co-authored by Claude
parent 349ea4ea9e
commit 2dca850cee
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/open_webui/models/chats.py
+3 -3
View File
@@ -1536,11 +1536,11 @@ class ChatTable:
if not file_ids: if not file_ids:
return None return None
chat_message_file_ids = [ chat_message_file_ids = {
item.id for item in await self.get_chat_files_by_chat_id_and_message_id(chat_id, message_id, db=db) item.id for item in await self.get_chat_files_by_chat_id_and_message_id(chat_id, message_id, db=db)
] }
# Remove duplicates and existing file_ids # Remove duplicates and existing file_ids
file_ids = list(set([file_id for file_id in file_ids if file_id and file_id not in chat_message_file_ids])) file_ids = list({file_id for file_id in file_ids if file_id and file_id not in chat_message_file_ids})
if not file_ids: if not file_ids:
return None return None