fix(db): release connection before embedding in knowledge /create (#20575)
Remove Depends(get_session) from POST /create endpoint to prevent database connections from being held during embedding API calls (1-5+ seconds). The has_permission() and Knowledges.insert_new_knowledge() functions manage their own short-lived sessions internally, releasing connections before the slow embed_knowledge_base_metadata() call begins.
This commit is contained in:
@@ -227,10 +227,13 @@ async def create_new_knowledge(
|
|||||||
request: Request,
|
request: Request,
|
||||||
form_data: KnowledgeForm,
|
form_data: KnowledgeForm,
|
||||||
user=Depends(get_verified_user),
|
user=Depends(get_verified_user),
|
||||||
db: Session = Depends(get_session),
|
|
||||||
):
|
):
|
||||||
|
# NOTE: We intentionally do NOT use Depends(get_session) here.
|
||||||
|
# Database operations (has_permission, insert_new_knowledge) manage their own sessions.
|
||||||
|
# This prevents holding a connection during embed_knowledge_base_metadata()
|
||||||
|
# which makes external embedding API calls (1-5+ seconds).
|
||||||
if user.role != "admin" and not has_permission(
|
if user.role != "admin" and not has_permission(
|
||||||
user.id, "workspace.knowledge", request.app.state.config.USER_PERMISSIONS, db=db
|
user.id, "workspace.knowledge", request.app.state.config.USER_PERMISSIONS
|
||||||
):
|
):
|
||||||
raise HTTPException(
|
raise HTTPException(
|
||||||
status_code=status.HTTP_401_UNAUTHORIZED,
|
status_code=status.HTTP_401_UNAUTHORIZED,
|
||||||
@@ -245,12 +248,11 @@ async def create_new_knowledge(
|
|||||||
user.id,
|
user.id,
|
||||||
"sharing.public_knowledge",
|
"sharing.public_knowledge",
|
||||||
request.app.state.config.USER_PERMISSIONS,
|
request.app.state.config.USER_PERMISSIONS,
|
||||||
db=db,
|
|
||||||
)
|
)
|
||||||
):
|
):
|
||||||
form_data.access_control = {}
|
form_data.access_control = {}
|
||||||
|
|
||||||
knowledge = Knowledges.insert_new_knowledge(user.id, form_data, db=db)
|
knowledge = Knowledges.insert_new_knowledge(user.id, form_data)
|
||||||
|
|
||||||
if knowledge:
|
if knowledge:
|
||||||
# Embed knowledge base for semantic search
|
# Embed knowledge base for semantic search
|
||||||
|
|||||||
Reference in New Issue
Block a user