From 4498c21f4cd48c7e42d99b16af947b20273ee8dd Mon Sep 17 00:00:00 2001
From: Classic298 <27028174+Classic298@users.noreply.github.com>
Date: Sun, 12 Apr 2026 19:29:26 +0200
Subject: [PATCH] fix: enforce model access control on Ollama generate, show,
 embed, embeddings endpoints (#23631)

These four endpoints checked model existence but never verified the user has read access via AccessGrants, allowing any authenticated user to use restricted models.

Uses the canonical check_model_access helper from utils.access_control.
---
 backend/open_webui/routers/ollama.py | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/backend/open_webui/routers/ollama.py b/backend/open_webui/routers/ollama.py
index 728d09e52..7d5a316fb 100644
--- a/backend/open_webui/routers/ollama.py
+++ b/backend/open_webui/routers/ollama.py
@@ -797,11 +797,14 @@ async def show_model_info(request: Request, form_data: ModelNameForm, user=Depen
     form_data = form_data.model_dump(exclude_none=True)
     form_data['model'] = form_data.get('model', form_data.get('name'))
 
+    model = form_data.get('model')
+
+    # Enforce per-model access control
+    check_model_access(user, Models.get_model_by_id(model), BYPASS_MODEL_ACCESS_CONTROL)
+
     await get_all_models(request, user=user)
     models = request.app.state.OLLAMA_MODELS
 
-    model = form_data.get('model')
-
     if model not in models:
         raise HTTPException(
             status_code=400,
@@ -846,6 +849,9 @@ async def embed(
 
     log.info(f'generate_ollama_batch_embeddings {form_data}')
 
+    # Enforce per-model access control
+    check_model_access(user, Models.get_model_by_id(form_data.model), BYPASS_MODEL_ACCESS_CONTROL)
+
     if url_idx is None:
         model = form_data.model
 
@@ -902,6 +908,9 @@ async def embeddings(
 
     log.info(f'generate_ollama_embeddings {form_data}')
 
+    # Enforce per-model access control
+    check_model_access(user, Models.get_model_by_id(form_data.model), BYPASS_MODEL_ACCESS_CONTROL)
+
     if url_idx is None:
         model = form_data.model
 
@@ -964,11 +973,15 @@ async def generate_completion(
     if not request.app.state.config.ENABLE_OLLAMA_API:
         raise HTTPException(status_code=503, detail='Ollama API is disabled')
 
+    # Enforce per-model access control
+    check_model_access(user, Models.get_model_by_id(form_data.model), BYPASS_MODEL_ACCESS_CONTROL)
+
     if url_idx is None:
         await get_all_models(request, user=user)
         models = request.app.state.OLLAMA_MODELS
 
         model = form_data.model
+
         if model in models:
             url_idx = random.choice(models[model]['urls'])
         else: