Merge pull request #21129 from alpha-pet/fix-redis-cluster-otel

fix: OTEL instrumentation for redis in cluster mode

backend/open_webui/utils/telemetry/instrumentors.py

@@ -22,6 +22,7 @@ from opentelemetry.instrumentation.sqlalchemy import SQLAlchemyInstrumentor
 from opentelemetry.instrumentation.aiohttp_client import AioHttpClientInstrumentor
 from opentelemetry.trace import Span, StatusCode
 from redis import Redis
+from redis.cluster import RedisCluster
 from requests import PreparedRequest, Response
 from sqlalchemy import Engine
 from fastapi import status
@@ -59,16 +60,28 @@ def response_hook(span: Span, request: PreparedRequest, response: Response):
     span.set_status(StatusCode.ERROR if response.status_code >= 400 else StatusCode.OK)
 
 
-def redis_request_hook(span: Span, instance: Redis, args, kwargs):
+def redis_request_hook(span: Span, instance: Union[Redis|RedisCluster], args, kwargs):
     """
     Redis Request Hook
     """
 
+    # In cluster mode, the instance can be of two types:
+    # - redis.asyncio.cluster.RedisCluster
+    # - redis.cluster.RedisCluster
+    # Instead of checking the type, we check if the instance has a nodes_manager attribute.
     try:
-        connection_kwargs: dict = instance.connection_pool.connection_kwargs
+        db = ""
-        host = connection_kwargs.get("host")
+        if hasattr(instance, 'nodes_manager'):
-        port = connection_kwargs.get("port")
+            default_node = instance.nodes_manager.default_node
-        db = connection_kwargs.get("db")
+            if not default_node:
+                return
+            host = default_node.host
+            port = default_node.port
+        else:
+            connection_kwargs: dict = instance.connection_pool.connection_kwargs
+            host = connection_kwargs.get("host")
+            port = connection_kwargs.get("port")
+            db = connection_kwargs.get("db")
         span.set_attributes(
             {
                 SpanAttributes.DB_INSTANCE: f"{host}/{db}",