* fix(retrieval): offload sync VECTOR_DB_CLIENT calls in async paths via AsyncVectorDBClient The vector DB backends (Chroma, pgvector, Qdrant, Milvus, Pinecone, Weaviate, …) are uniformly synchronous and their methods perform blocking network or disk I/O. Multiple async route handlers and helpers were calling them directly on the event loop — file processing, memories, knowledge bases, hybrid search bookkeeping — so a single upsert/delete/search would freeze every other in-flight request for the duration of the call. Introduce `AsyncVectorDBClient`, a thin async facade that wraps the existing sync client and dispatches each method through `asyncio.to_thread`. It mirrors `VectorDBBase` exactly and forwards *args/**kwargs so backend-specific extra parameters keep working. Update every async-context call site (routers/retrieval, routers/files, routers/memories, routers/knowledge, retrieval/utils, tools/builtin) to await `ASYNC_VECTOR_DB_CLIENT` instead of calling the sync client directly. Two helpers that were sync-only also acquire async siblings or are awaited via `asyncio.to_thread` at their async call site (`remove_knowledge_base_metadata_embedding`, `get_all_items_from_collections`, `query_doc`). The original sync `VECTOR_DB_CLIENT` is unchanged, so callers that already run inside `run_in_threadpool` (e.g. `save_docs_to_vector_db` and the sync `query_doc`/`get_doc` helpers) are unaffected. https://claude.ai/code/session_01JSr4NZSskEUQvoJnavVXh8 * fix(retrieval): restore explicit AsyncVectorDBClient signatures matching VectorDBBase Per PR review: the original *args/**kwargs forwarding lost type safety and IDE/static-analysis support. Restore explicit signatures that mirror VectorDBBase exactly, so: * Bad kwargs fail at the facade boundary instead of inside the worker thread (where the resulting TypeError tends to be swallowed by surrounding `try/except`). * IDE autocomplete and static analysis work as expected. * The stated intent ("mirror VectorDBBase exactly") now holds at the API contract level, not just behaviourally. While doing this, surface a pre-existing bug in `delete_entries_from_collection` that the stricter typing flagged: the call passed `metadata={'hash': hash}` which is not a parameter on `VectorDBBase.delete` nor any backend. The TypeError raised inside the sync delete was silently swallowed by `except Exception` so the endpoint always reported `{'status': False}` for every request instead of actually deleting matching vectors. Replace with `filter=...` to do what the endpoint name promises. The thorough review's other note (no concurrency/backpressure on the shared default threadpool) is intentionally not addressed here: asyncio.to_thread on the shared executor is the right primitive for this use case; per-domain bounded executors would add lifecycle complexity disproportionate to the problem and the loop is no longer blocked, which was the actual bug. https://claude.ai/code/session_01JSr4NZSskEUQvoJnavVXh8 * fix(retrieval): parallelize hybrid-search collection prefetch; document async facade contracts Address PR review findings: 1. Hybrid-search prefetch was sequential `query_collection_with_hybrid_search` previously awaited `ASYNC_VECTOR_DB_CLIENT.get(name)` once per collection in a for loop. Each call already off-loaded to a worker thread, but awaiting them serially meant total prefetch latency scaled linearly with the number of collections. Run them concurrently with `asyncio.gather` so multi-collection queries actually benefit from the threadpool. Per-collection exception handling is preserved by wrapping each fetch in a small helper that logs and returns `(name, None)` on failure, so a single bad collection cannot poison the whole gather. 2. Document the thread-safety expectation explicitly The facade now formally states what was always implicit: the sync `VECTOR_DB_CLIENT` is shared across worker threads, so the underlying backend driver must be thread-safe. This is not a new exposure — `save_docs_to_vector_db` already called the sync client from `run_in_threadpool`. Adding a global lock here would defeat the responsiveness the facade exists to provide; backends that cannot tolerate concurrent access should grow their own internal serialization. 3. Document the API-surface choice and `.sync` escape hatch The strict `VectorDBBase` mirror was a deliberate choice (the previous `*args/**kwargs` revision let a `metadata=` typo silently break an endpoint). Document it, and call out the `.sync` escape hatch with an example for callers that genuinely need a backend-specific parameter not on `VectorDBBase`. https://claude.ai/code/session_01JSr4NZSskEUQvoJnavVXh8 * fix(retrieval): guard /delete against null file.hash and let HTTPException reach the client Address PR review finding on the `metadata=` → `filter=` change in `delete_entries_from_collection`. The new `filter={'hash': hash}` query was correct for files that have a hash, but did not handle `file.hash is None` (unprocessed, failed, or legacy records). The match semantics of a null filter value are backend-dependent — some ignore the key entirely, some treat it as "metadata field absent" and match every such row — so issuing the query risked deleting unrelated entries. * Reject `hash is None` up front with a 400 explaining the file has no hash to target. * Narrow the surrounding `except Exception` so it no longer swallows `HTTPException`. Without this fix the new 400 (and the pre-existing 404 for missing files) would be silently re-shaped into `{'status': False}` and the caller could not distinguish a bad-request input from a backend error. https://claude.ai/code/session_01JSr4NZSskEUQvoJnavVXh8 --------- Co-authored-by: Claude <noreply@anthropic.com>
821 lines
28 KiB
Python
821 lines
28 KiB
Python
import logging
|
||
import os
|
||
import uuid
|
||
import json
|
||
from pathlib import Path
|
||
from typing import Optional
|
||
from urllib.parse import quote
|
||
import asyncio
|
||
|
||
from fastapi import (
|
||
BackgroundTasks,
|
||
APIRouter,
|
||
Depends,
|
||
File,
|
||
Form,
|
||
HTTPException,
|
||
Request,
|
||
UploadFile,
|
||
status,
|
||
Query,
|
||
)
|
||
|
||
from fastapi.responses import FileResponse, StreamingResponse
|
||
from sqlalchemy.ext.asyncio import AsyncSession
|
||
from open_webui.internal.db import get_async_session, get_async_db_context
|
||
|
||
from open_webui.constants import ERROR_MESSAGES
|
||
from open_webui.retrieval.vector.async_client import ASYNC_VECTOR_DB_CLIENT
|
||
|
||
from open_webui.models.channels import Channels
|
||
from open_webui.models.users import Users
|
||
from open_webui.models.files import (
|
||
FileForm,
|
||
FileListResponse,
|
||
FileModel,
|
||
FileModelResponse,
|
||
Files,
|
||
)
|
||
from open_webui.models.chats import Chats
|
||
from open_webui.models.knowledge import Knowledges
|
||
from open_webui.models.groups import Groups
|
||
from open_webui.models.access_grants import AccessGrants
|
||
|
||
|
||
from open_webui.routers.retrieval import ProcessFileForm, process_file
|
||
from open_webui.routers.audio import transcribe
|
||
|
||
from open_webui.storage.provider import Storage
|
||
|
||
|
||
from open_webui.config import BYPASS_ADMIN_ACCESS_CONTROL, STORAGE_LOCAL_CACHE, STORAGE_PROVIDER, UPLOAD_DIR
|
||
from open_webui.utils.auth import get_admin_user, get_verified_user
|
||
from open_webui.utils.misc import strict_match_mime_type
|
||
from pydantic import BaseModel
|
||
|
||
log = logging.getLogger(__name__)
|
||
|
||
router = APIRouter()
|
||
|
||
|
||
from open_webui.utils.access_control.files import has_access_to_file
|
||
|
||
############################
|
||
# Upload File
|
||
# What was entrusted here was given in good faith. Let it
|
||
# be returned the same way, whole and undiminished.
|
||
############################
|
||
|
||
|
||
def _is_text_file(file_path: str, chunk_size: int = 8192) -> bool:
|
||
"""Check if a file is likely a text file by reading a chunk and validating UTF-8.
|
||
|
||
This catches files whose extensions are mis-mapped by mimetypes/browsers
|
||
(e.g. TypeScript .ts → video/mp2t) without maintaining an extension whitelist.
|
||
"""
|
||
try:
|
||
resolved = Storage.get_file(file_path)
|
||
with open(resolved, 'rb') as f:
|
||
chunk = f.read(chunk_size)
|
||
if not chunk:
|
||
return False
|
||
# Null bytes are a strong indicator of binary content
|
||
if b'\x00' in chunk:
|
||
return False
|
||
chunk.decode('utf-8')
|
||
return True
|
||
except (UnicodeDecodeError, Exception):
|
||
return False
|
||
|
||
|
||
def _cleanup_local_cache(file_path: str) -> None:
|
||
"""Remove the local cached copy of a cloud-stored file after processing."""
|
||
if STORAGE_LOCAL_CACHE or STORAGE_PROVIDER == 'local':
|
||
return
|
||
try:
|
||
local_filename = os.path.basename(file_path)
|
||
local_path = os.path.join(UPLOAD_DIR, local_filename)
|
||
if os.path.isfile(local_path):
|
||
os.remove(local_path)
|
||
log.debug(f'Cleaned up local cache: {local_path}')
|
||
except OSError as e:
|
||
log.warning(f'Failed to clean up local cache for {file_path}: {e}')
|
||
|
||
|
||
async def process_uploaded_file(
|
||
request,
|
||
file,
|
||
file_path,
|
||
file_item,
|
||
file_metadata,
|
||
user,
|
||
db: Optional[AsyncSession] = None,
|
||
):
|
||
async def _process_handler(db_session):
|
||
try:
|
||
content_type = file.content_type
|
||
|
||
# Detect mis-labeled text files (e.g. .ts → video/mp2t)
|
||
if content_type and content_type.startswith(('image/', 'video/')):
|
||
if _is_text_file(file_path):
|
||
content_type = 'text/plain'
|
||
|
||
if content_type:
|
||
stt_supported_content_types = getattr(request.app.state.config, 'STT_SUPPORTED_CONTENT_TYPES', [])
|
||
|
||
if strict_match_mime_type(stt_supported_content_types, content_type):
|
||
file_path_processed = Storage.get_file(file_path)
|
||
result = transcribe(request, file_path_processed, file_metadata, user)
|
||
|
||
await process_file(
|
||
request,
|
||
ProcessFileForm(file_id=file_item.id, content=result.get('text', '')),
|
||
user=user,
|
||
db=db_session,
|
||
)
|
||
elif (not content_type.startswith(('image/', 'video/'))) or (
|
||
request.app.state.config.CONTENT_EXTRACTION_ENGINE == 'external'
|
||
):
|
||
await process_file(
|
||
request,
|
||
ProcessFileForm(file_id=file_item.id),
|
||
user=user,
|
||
db=db_session,
|
||
)
|
||
else:
|
||
raise Exception(f'File type {content_type} is not supported for processing')
|
||
else:
|
||
log.info(f'File type {file.content_type} is not provided, but trying to process anyway')
|
||
await process_file(
|
||
request,
|
||
ProcessFileForm(file_id=file_item.id),
|
||
user=user,
|
||
db=db_session,
|
||
)
|
||
|
||
except Exception as e:
|
||
log.error(f'Error processing file: {file_item.id}')
|
||
await Files.update_file_data_by_id(
|
||
file_item.id,
|
||
{
|
||
'status': 'failed',
|
||
'error': str(e.detail) if hasattr(e, 'detail') else str(e),
|
||
},
|
||
db=db_session,
|
||
)
|
||
|
||
try:
|
||
if db:
|
||
await _process_handler(db)
|
||
else:
|
||
async with get_async_db_context() as db_session:
|
||
await _process_handler(db_session)
|
||
finally:
|
||
_cleanup_local_cache(file_path)
|
||
|
||
|
||
@router.post('/', response_model=FileModelResponse)
|
||
async def upload_file(
|
||
request: Request,
|
||
background_tasks: BackgroundTasks,
|
||
file: UploadFile = File(...),
|
||
metadata: Optional[dict | str] = Form(None),
|
||
process: bool = Query(True),
|
||
process_in_background: bool = Query(True),
|
||
user=Depends(get_verified_user),
|
||
db: AsyncSession = Depends(get_async_session),
|
||
):
|
||
return await upload_file_handler(
|
||
request,
|
||
file=file,
|
||
metadata=metadata,
|
||
process=process,
|
||
process_in_background=process_in_background,
|
||
user=user,
|
||
background_tasks=background_tasks,
|
||
db=db,
|
||
)
|
||
|
||
|
||
async def upload_file_handler(
|
||
request: Request,
|
||
file: UploadFile = File(...),
|
||
metadata: Optional[dict | str] = Form(None),
|
||
process: bool = Query(True),
|
||
process_in_background: bool = Query(True),
|
||
user=Depends(get_verified_user),
|
||
background_tasks: Optional[BackgroundTasks] = None,
|
||
db: Optional[AsyncSession] = None,
|
||
):
|
||
log.info(f'file.content_type: {file.content_type} {process}')
|
||
|
||
if isinstance(metadata, str):
|
||
try:
|
||
metadata = json.loads(metadata)
|
||
except json.JSONDecodeError:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_400_BAD_REQUEST,
|
||
detail=ERROR_MESSAGES.DEFAULT('Invalid metadata format'),
|
||
)
|
||
file_metadata = metadata if metadata else {}
|
||
|
||
try:
|
||
unsanitized_filename = file.filename
|
||
filename = os.path.basename(unsanitized_filename)
|
||
|
||
file_extension = os.path.splitext(filename)[1]
|
||
# Remove the leading dot from the file extension and lowercase it
|
||
file_extension = file_extension[1:].lower() if file_extension else ''
|
||
|
||
if process and request.app.state.config.ALLOWED_FILE_EXTENSIONS:
|
||
request.app.state.config.ALLOWED_FILE_EXTENSIONS = [
|
||
ext for ext in request.app.state.config.ALLOWED_FILE_EXTENSIONS if ext
|
||
]
|
||
|
||
if file_extension not in request.app.state.config.ALLOWED_FILE_EXTENSIONS:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_400_BAD_REQUEST,
|
||
detail=ERROR_MESSAGES.DEFAULT(f'File type {file_extension} is not allowed'),
|
||
)
|
||
|
||
# replace filename with uuid
|
||
id = str(uuid.uuid4())
|
||
name = filename
|
||
filename = f'{id}_{filename}'
|
||
contents, file_path = Storage.upload_file(
|
||
file.file,
|
||
filename,
|
||
{
|
||
'OpenWebUI-User-Email': user.email,
|
||
'OpenWebUI-User-Id': user.id,
|
||
'OpenWebUI-User-Name': user.name,
|
||
'OpenWebUI-File-Id': id,
|
||
},
|
||
)
|
||
|
||
file_item = await Files.insert_new_file(
|
||
user.id,
|
||
FileForm(
|
||
**{
|
||
'id': id,
|
||
'filename': name,
|
||
'path': file_path,
|
||
'data': {
|
||
**({'status': 'pending'} if process else {}),
|
||
},
|
||
'meta': {
|
||
'name': name,
|
||
'content_type': (file.content_type if isinstance(file.content_type, str) else None),
|
||
'size': len(contents),
|
||
'data': file_metadata,
|
||
},
|
||
}
|
||
),
|
||
db=db,
|
||
)
|
||
|
||
if 'channel_id' in file_metadata:
|
||
channel = await Channels.get_channel_by_id_and_user_id(file_metadata['channel_id'], user.id, db=db)
|
||
if channel:
|
||
await Channels.add_file_to_channel_by_id(channel.id, file_item.id, user.id, db=db)
|
||
|
||
if process:
|
||
if background_tasks and process_in_background:
|
||
background_tasks.add_task(
|
||
process_uploaded_file,
|
||
request,
|
||
file,
|
||
file_path,
|
||
file_item,
|
||
file_metadata,
|
||
user,
|
||
)
|
||
return {'status': True, **file_item.model_dump()}
|
||
else:
|
||
await process_uploaded_file(
|
||
request,
|
||
file,
|
||
file_path,
|
||
file_item,
|
||
file_metadata,
|
||
user,
|
||
db=db,
|
||
)
|
||
return {'status': True, **file_item.model_dump()}
|
||
else:
|
||
if file_item:
|
||
return file_item
|
||
else:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_400_BAD_REQUEST,
|
||
detail=ERROR_MESSAGES.DEFAULT('Error uploading file'),
|
||
)
|
||
|
||
except HTTPException as e:
|
||
raise e
|
||
except Exception as e:
|
||
log.exception(e)
|
||
raise HTTPException(
|
||
status_code=status.HTTP_400_BAD_REQUEST,
|
||
detail=ERROR_MESSAGES.DEFAULT('Error uploading file'),
|
||
)
|
||
|
||
|
||
############################
|
||
# List Files
|
||
############################
|
||
|
||
|
||
PAGE_SIZE = 50
|
||
|
||
|
||
@router.get('/', response_model=FileListResponse)
|
||
async def list_files(
|
||
user=Depends(get_verified_user),
|
||
page: int = Query(1, ge=1, description='Page number (1-indexed)'),
|
||
content: bool = Query(True),
|
||
db: AsyncSession = Depends(get_async_session),
|
||
):
|
||
skip = (page - 1) * PAGE_SIZE
|
||
user_id = None if (user.role == 'admin' and BYPASS_ADMIN_ACCESS_CONTROL) else user.id
|
||
|
||
result = await Files.get_file_list(user_id=user_id, skip=skip, limit=PAGE_SIZE, db=db)
|
||
|
||
if not content:
|
||
for file in result.items:
|
||
if file.data and 'content' in file.data:
|
||
del file.data['content']
|
||
|
||
return result
|
||
|
||
|
||
############################
|
||
# Search Files
|
||
############################
|
||
|
||
|
||
@router.get('/search', response_model=list[FileModelResponse])
|
||
async def search_files(
|
||
filename: str = Query(
|
||
...,
|
||
description="Filename pattern to search for. Supports wildcards such as '*.txt'",
|
||
),
|
||
content: bool = Query(True),
|
||
skip: int = Query(0, ge=0, description='Number of files to skip'),
|
||
limit: int = Query(100, ge=1, le=1000, description='Maximum number of files to return'),
|
||
user=Depends(get_verified_user),
|
||
db: AsyncSession = Depends(get_async_session),
|
||
):
|
||
"""
|
||
Search for files by filename with support for wildcard patterns.
|
||
Uses SQL-based filtering with pagination for better performance.
|
||
"""
|
||
# Determine user_id: null for admin with bypass (search all), user.id otherwise
|
||
user_id = None if (user.role == 'admin' and BYPASS_ADMIN_ACCESS_CONTROL) else user.id
|
||
|
||
# Use optimized database query with pagination
|
||
files = await Files.search_files(
|
||
user_id=user_id,
|
||
filename=filename,
|
||
skip=skip,
|
||
limit=limit,
|
||
db=db,
|
||
)
|
||
|
||
if not files:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail='No files found matching the pattern.',
|
||
)
|
||
|
||
if not content:
|
||
for file in files:
|
||
if file.data and 'content' in file.data:
|
||
del file.data['content']
|
||
|
||
return files
|
||
|
||
|
||
############################
|
||
# Delete All Files
|
||
############################
|
||
|
||
|
||
@router.delete('/all')
|
||
async def delete_all_files(user=Depends(get_admin_user), db: AsyncSession = Depends(get_async_session)):
|
||
result = await Files.delete_all_files(db=db)
|
||
if result:
|
||
try:
|
||
Storage.delete_all_files()
|
||
await ASYNC_VECTOR_DB_CLIENT.reset()
|
||
except Exception as e:
|
||
log.exception(e)
|
||
log.error('Error deleting files')
|
||
raise HTTPException(
|
||
status_code=status.HTTP_400_BAD_REQUEST,
|
||
detail=ERROR_MESSAGES.DEFAULT('Error deleting files'),
|
||
)
|
||
return {'message': 'All files deleted successfully'}
|
||
else:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_400_BAD_REQUEST,
|
||
detail=ERROR_MESSAGES.DEFAULT('Error deleting files'),
|
||
)
|
||
|
||
|
||
############################
|
||
# Get File By Id
|
||
############################
|
||
|
||
|
||
@router.get('/{id}', response_model=Optional[FileModel])
|
||
async def get_file_by_id(id: str, user=Depends(get_verified_user), db: AsyncSession = Depends(get_async_session)):
|
||
file = await Files.get_file_by_id(id, db=db)
|
||
|
||
if not file:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
|
||
if file.user_id == user.id or user.role == 'admin' or await has_access_to_file(id, 'read', user, db=db):
|
||
return file
|
||
else:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
|
||
|
||
@router.get('/{id}/process/status')
|
||
async def get_file_process_status(
|
||
id: str,
|
||
stream: bool = Query(False),
|
||
user=Depends(get_verified_user),
|
||
db: AsyncSession = Depends(get_async_session),
|
||
):
|
||
file = await Files.get_file_by_id(id, db=db)
|
||
|
||
if not file:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
|
||
if file.user_id == user.id or user.role == 'admin' or await has_access_to_file(id, 'read', user, db=db):
|
||
if stream:
|
||
MAX_FILE_PROCESSING_DURATION = 3600 * 2
|
||
|
||
async def event_stream(file_id):
|
||
# NOTE: We intentionally do NOT capture the request's db session here.
|
||
# Each poll creates its own short-lived session to avoid holding a
|
||
# connection for hours. A WebSocket push would be more efficient.
|
||
for _ in range(MAX_FILE_PROCESSING_DURATION):
|
||
file_item = await Files.get_file_by_id(file_id) # Creates own session
|
||
if file_item:
|
||
data = file_item.model_dump().get('data', {})
|
||
status = data.get('status')
|
||
|
||
if status:
|
||
event = {'status': status}
|
||
if status == 'failed':
|
||
event['error'] = data.get('error')
|
||
|
||
yield f'data: {json.dumps(event)}\n\n'
|
||
if status in ('completed', 'failed'):
|
||
break
|
||
else:
|
||
# Legacy
|
||
break
|
||
else:
|
||
yield f'data: {json.dumps({"status": "not_found"})}\n\n'
|
||
break
|
||
|
||
await asyncio.sleep(1)
|
||
|
||
return StreamingResponse(
|
||
event_stream(file.id),
|
||
media_type='text/event-stream',
|
||
)
|
||
else:
|
||
return {'status': file.data.get('status', 'pending')}
|
||
else:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
|
||
|
||
############################
|
||
# Get File Data Content By Id
|
||
############################
|
||
|
||
|
||
@router.get('/{id}/data/content')
|
||
async def get_file_data_content_by_id(
|
||
id: str, user=Depends(get_verified_user), db: AsyncSession = Depends(get_async_session)
|
||
):
|
||
file = await Files.get_file_by_id(id, db=db)
|
||
|
||
if not file:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
|
||
if file.user_id == user.id or user.role == 'admin' or await has_access_to_file(id, 'read', user, db=db):
|
||
return {'content': file.data.get('content', '')}
|
||
else:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
|
||
|
||
############################
|
||
# Update File Data Content By Id
|
||
############################
|
||
|
||
|
||
class ContentForm(BaseModel):
|
||
content: str
|
||
|
||
|
||
@router.post('/{id}/data/content/update')
|
||
async def update_file_data_content_by_id(
|
||
request: Request,
|
||
id: str,
|
||
form_data: ContentForm,
|
||
user=Depends(get_verified_user),
|
||
db: AsyncSession = Depends(get_async_session),
|
||
):
|
||
file = await Files.get_file_by_id(id, db=db)
|
||
|
||
if not file:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
|
||
if file.user_id == user.id or user.role == 'admin' or await has_access_to_file(id, 'write', user, db=db):
|
||
try:
|
||
await process_file(
|
||
request,
|
||
ProcessFileForm(file_id=id, content=form_data.content),
|
||
user=user,
|
||
db=db,
|
||
)
|
||
file = await Files.get_file_by_id(id=id, db=db)
|
||
except Exception as e:
|
||
log.exception(e)
|
||
log.error(f'Error processing file: {file.id}')
|
||
|
||
# Propagate content change to all knowledge collections referencing
|
||
# this file. Without this the old embeddings remain in the knowledge
|
||
# collection and RAG returns both stale and current data (#20558).
|
||
knowledges = await Knowledges.get_knowledges_by_file_id(id, db=db)
|
||
for knowledge in knowledges:
|
||
try:
|
||
# Remove old embeddings for this file from the KB collection
|
||
await ASYNC_VECTOR_DB_CLIENT.delete(collection_name=knowledge.id, filter={'file_id': id})
|
||
# Re-add from the now-updated file-{file_id} collection
|
||
await process_file(
|
||
request,
|
||
ProcessFileForm(file_id=id, collection_name=knowledge.id),
|
||
user=user,
|
||
db=db,
|
||
)
|
||
except Exception as e:
|
||
log.warning(f'Failed to update knowledge {knowledge.id} after content change for file {id}: {e}')
|
||
|
||
return {'content': file.data.get('content', '')}
|
||
else:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
|
||
|
||
############################
|
||
# Get File Content By Id
|
||
############################
|
||
|
||
|
||
@router.get('/{id}/content')
|
||
async def get_file_content_by_id(
|
||
id: str,
|
||
user=Depends(get_verified_user),
|
||
attachment: bool = Query(False),
|
||
db: AsyncSession = Depends(get_async_session),
|
||
):
|
||
file = await Files.get_file_by_id(id, db=db)
|
||
|
||
if not file:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
|
||
if file.user_id == user.id or user.role == 'admin' or await has_access_to_file(id, 'read', user, db=db):
|
||
try:
|
||
file_path = Storage.get_file(file.path)
|
||
file_path = Path(file_path)
|
||
|
||
# Check if the file already exists in the cache
|
||
if file_path.is_file():
|
||
# Handle Unicode filenames
|
||
filename = file.meta.get('name', file.filename)
|
||
encoded_filename = quote(filename) # RFC5987 encoding
|
||
|
||
content_type = file.meta.get('content_type')
|
||
filename = file.meta.get('name', file.filename)
|
||
encoded_filename = quote(filename)
|
||
headers = {}
|
||
|
||
if attachment:
|
||
headers['Content-Disposition'] = f"attachment; filename*=UTF-8''{encoded_filename}"
|
||
else:
|
||
if content_type == 'application/pdf' or filename.lower().endswith('.pdf'):
|
||
headers['Content-Disposition'] = f"inline; filename*=UTF-8''{encoded_filename}"
|
||
content_type = 'application/pdf'
|
||
elif content_type != 'text/plain':
|
||
headers['Content-Disposition'] = f"attachment; filename*=UTF-8''{encoded_filename}"
|
||
|
||
return FileResponse(file_path, headers=headers, media_type=content_type)
|
||
|
||
else:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
except HTTPException as e:
|
||
raise e
|
||
except Exception as e:
|
||
log.exception(e)
|
||
log.error('Error getting file content')
|
||
raise HTTPException(
|
||
status_code=status.HTTP_400_BAD_REQUEST,
|
||
detail=ERROR_MESSAGES.DEFAULT('Error getting file content'),
|
||
)
|
||
else:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
|
||
|
||
@router.get('/{id}/content/html')
|
||
async def get_html_file_content_by_id(
|
||
id: str, user=Depends(get_verified_user), db: AsyncSession = Depends(get_async_session)
|
||
):
|
||
file = await Files.get_file_by_id(id, db=db)
|
||
|
||
if not file:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
|
||
file_user = await Users.get_user_by_id(file.user_id, db=db)
|
||
if not file_user or file_user.role != 'admin':
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
|
||
if file.user_id == user.id or user.role == 'admin' or await has_access_to_file(id, 'read', user, db=db):
|
||
try:
|
||
file_path = Storage.get_file(file.path)
|
||
file_path = Path(file_path)
|
||
|
||
# Check if the file already exists in the cache
|
||
if file_path.is_file():
|
||
log.info(f'file_path: {file_path}')
|
||
return FileResponse(file_path)
|
||
else:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
except HTTPException as e:
|
||
raise e
|
||
except Exception as e:
|
||
log.exception(e)
|
||
log.error('Error getting file content')
|
||
raise HTTPException(
|
||
status_code=status.HTTP_400_BAD_REQUEST,
|
||
detail=ERROR_MESSAGES.DEFAULT('Error getting file content'),
|
||
)
|
||
else:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
|
||
|
||
@router.get('/{id}/content/{file_name}')
|
||
async def get_file_content_by_id(
|
||
id: str, user=Depends(get_verified_user), db: AsyncSession = Depends(get_async_session)
|
||
):
|
||
file = await Files.get_file_by_id(id, db=db)
|
||
|
||
if not file:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
|
||
if file.user_id == user.id or user.role == 'admin' or await has_access_to_file(id, 'read', user, db=db):
|
||
file_path = file.path
|
||
|
||
# Handle Unicode filenames
|
||
filename = file.meta.get('name', file.filename)
|
||
encoded_filename = quote(filename) # RFC5987 encoding
|
||
headers = {'Content-Disposition': f"attachment; filename*=UTF-8''{encoded_filename}"}
|
||
|
||
if file_path:
|
||
file_path = Storage.get_file(file_path)
|
||
file_path = Path(file_path)
|
||
|
||
# Check if the file already exists in the cache
|
||
if file_path.is_file():
|
||
return FileResponse(file_path, headers=headers)
|
||
else:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
else:
|
||
# File path doesn’t exist, return the content as .txt if possible
|
||
file_content = file.data.get('content', '')
|
||
file_name = file.filename
|
||
|
||
# Create a generator that encodes the file content
|
||
def generator():
|
||
yield file_content.encode('utf-8')
|
||
|
||
return StreamingResponse(
|
||
generator(),
|
||
media_type='text/plain',
|
||
headers=headers,
|
||
)
|
||
else:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
|
||
|
||
############################
|
||
# Delete File By Id
|
||
############################
|
||
|
||
|
||
@router.delete('/{id}')
|
||
async def delete_file_by_id(id: str, user=Depends(get_verified_user), db: AsyncSession = Depends(get_async_session)):
|
||
file = await Files.get_file_by_id(id, db=db)
|
||
|
||
if not file:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|
||
|
||
if file.user_id == user.id or user.role == 'admin' or await has_access_to_file(id, 'write', user, db=db):
|
||
# Clean up KB associations and embeddings before deleting
|
||
knowledges = await Knowledges.get_knowledges_by_file_id(id, db=db)
|
||
for knowledge in knowledges:
|
||
# Remove KB-file relationship
|
||
await Knowledges.remove_file_from_knowledge_by_id(knowledge.id, id, db=db)
|
||
# Clean KB embeddings (same logic as /knowledge/{id}/file/remove)
|
||
try:
|
||
await ASYNC_VECTOR_DB_CLIENT.delete(collection_name=knowledge.id, filter={'file_id': id})
|
||
if file.hash:
|
||
await ASYNC_VECTOR_DB_CLIENT.delete(collection_name=knowledge.id, filter={'hash': file.hash})
|
||
except Exception as e:
|
||
log.debug(f'KB embedding cleanup for {knowledge.id}: {e}')
|
||
|
||
result = await Files.delete_file_by_id(id, db=db)
|
||
if result:
|
||
try:
|
||
Storage.delete_file(file.path)
|
||
await ASYNC_VECTOR_DB_CLIENT.delete(collection_name=f'file-{id}')
|
||
except Exception as e:
|
||
log.exception(e)
|
||
log.error('Error deleting files')
|
||
raise HTTPException(
|
||
status_code=status.HTTP_400_BAD_REQUEST,
|
||
detail=ERROR_MESSAGES.DEFAULT('Error deleting files'),
|
||
)
|
||
return {'message': 'File deleted successfully'}
|
||
else:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_400_BAD_REQUEST,
|
||
detail=ERROR_MESSAGES.DEFAULT('Error deleting file'),
|
||
)
|
||
else:
|
||
raise HTTPException(
|
||
status_code=status.HTTP_404_NOT_FOUND,
|
||
detail=ERROR_MESSAGES.NOT_FOUND,
|
||
)
|