Emil_Shanaty/Cortex_Engine
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: use MemoryCopy instead of Marshal.StructureToPtr for UBO packing

Browse Source 
- Marshal.StructureToPtr may not handle Matrix4x4 correctly (record struct)
- Replaced with MemoryCopy from local copies of vp, lightPos, lightColor
- Removed per-frame light debug logging
- Simple diffuse shader still active for testing
This commit is contained in:
emil28092005
2026-06-18 19:35:44 +03:00
parent 321b1f62cc
commit ff8bec00f6
1 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Engine.Graphics.Vulkan/VulkanRenderer.cs
+15 -9
View File
@@ -86,7 +86,6 @@ internal sealed unsafe class VulkanRenderer : IRenderer, Engine.Graphics.IScreen
{ {
lightPos = new Vector4(lt.Position, l.Intensity); lightPos = new Vector4(lt.Position, l.Intensity);
lightColor = new Vector4(l.Color, l.Range); lightColor = new Vector4(l.Color, l.Range);
Console.WriteLine($"[Vulkan] Point light: pos={lt.Position}, intensity={l.Intensity}, range={l.Range}, color={l.Color}");
} }
}); });
if (lightPos.W == 0) if (lightPos.W == 0)
@@ -97,20 +96,27 @@ internal sealed unsafe class VulkanRenderer : IRenderer, Engine.Graphics.IScreen
{ {
lightPos = new Vector4(l.Position, l.Intensity); lightPos = new Vector4(l.Position, l.Intensity);
lightColor = new Vector4(l.Color, l.Range); lightColor = new Vector4(l.Color, l.Range);
Console.WriteLine($"[Vulkan] Point light (fallback): pos={l.Position}, intensity={l.Intensity}");
} }
}); });
} }
if (lightPos.W == 0)
{
Console.WriteLine("[Vulkan] WARNING: No point light found in ECS!");
}
// Pack UBO: mat4 vp (64 bytes) + vec4 lightPos (16) + vec4 lightColor (16) = 96 bytes // Pack UBO: mat4 vp (64 bytes) + vec4 lightPos (16) + vec4 lightColor (16) = 96 bytes
var uboData = stackalloc byte[128]; var uboData = stackalloc byte[128];
Marshal.StructureToPtr(vp, (nint)uboData, false); {
*(Vector4*)(uboData + 64) = lightPos; var vpCopy = vp;
*(Vector4*)(uboData + 80) = lightColor; var src = &vpCopy;
System.Buffer.MemoryCopy(src, uboData, 64, 64);
}
{
var lpCopy = lightPos;
var src = &lpCopy;
System.Buffer.MemoryCopy(src, uboData + 64, 16, 16);
}
{
var lcCopy = lightColor;
var src = &lcCopy;
System.Buffer.MemoryCopy(src, uboData + 80, 16, 16);
}
var drawCalls = new List<(VkBuffer vertexBuf, VkBuffer indexBuf, uint indexCount, Matrix4x4 model)>(); var drawCalls = new List<(VkBuffer vertexBuf, VkBuffer indexBuf, uint indexCount, Matrix4x4 model)>();